-
Notifications
You must be signed in to change notification settings - Fork 51
feat!: Add ability to store breakpoint data in firebase realtime database #1076
Conversation
…ase (#1067) * Checkpoint on Firebase controller. Error handling and tests still need work. * Move api key and db url to the client's control * Some changes to work with the cli implementation - We now use a top level 'cdbg' node - Add timestamp with breakpoint is finalized - When a snapshot triggers, a separate node is used for the complete snapshot data under final. * Fix tests that relied on debuglet.stop(). Also disable the tests that aren't working yet, and remove a bunch of console.log messages. * Use underscores in label keys. * Replace console.log with util.debuglog. Co-authored-by: Jason Borg <jcborg@google.com>
* Fix and re-enable previously broken tests
This will provide a consistent log level throughout the codebase.
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 66.86% 66.11% -0.76%
==========================================
Files 20 21 +1
Lines 1648 1750 +102
Branches 335 352 +17
==========================================
+ Hits 1102 1157 +55
- Misses 469 510 +41
- Partials 77 83 +6
Continue to review full report at Codecov.
|
import * as stackdriver from '../types/stackdriver'; | ||
|
||
const BREAKPOINT_ACTION_MESSAGE = | ||
'The only currently supported breakpoint actions' + ' are CAPTURE and LOG.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think two strings need to be appended together here, confused me slightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cute. I'll fix that later; I assume that the linter moved the linebreak and it's solidly nonsense now.
Thanks for the reviews! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1071 🦕